You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In SysCTypes, we have c_intptr, c_uintptr and c_ptrdiff that all don't have the trailing _t. c_size_t and c_ssize_t are the only 2 that have the _t.
@mppf doesn't remember why it ended up this way. It might not have been intentional. If it was maybe it's that c_intptr is clear enough (we know int is a type) but c_size might sound like it means something else because size has many uses and isn't a type on its own in C. It looks like we've had this inconsistency at least since 2015.
Should we:
Change c_intptr c_uintptr c_ptrdiff to c_intptr_t c_uintptr_t c_ptrdiff_t (and also c_wchar)
Change c_size_t and c_ssize_t to c_size and c_ssize
Do nothing about it
The text was updated successfully, but these errors were encountered:
I'm in favor of 1 to consistently use the (c_ + C type name) convention. If this was something we did intentionally because the names are clear enough without _t, I still think the consistency is more valuable and there's not much benefit to leaving off the _t.
I tend to agree with @arifthpe here, though this it would've obviously been nicer if I'd noticed the inconsistency prior to 2.0.
I'll add that though consistency seems most attractive, I'm not sure I'd remove the _t from the c_[s]size_t tokens for the reason Michael gave in the OP. So, my ordered ranking would be:
Spin-off from #26828 (review)
In SysCTypes, we have c_intptr, c_uintptr and c_ptrdiff that all don't have the trailing _t. c_size_t and c_ssize_t are the only 2 that have the _t.
@mppf doesn't remember why it ended up this way. It might not have been intentional. If it was maybe it's that c_intptr is clear enough (we know int is a type) but c_size might sound like it means something else because size has many uses and isn't a type on its own in C. It looks like we've had this inconsistency at least since 2015.
Should we:
The text was updated successfully, but these errors were encountered: