-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next): dynamic consumer paths #623
base: main
Are you sure you want to change the base?
feat(next): dynamic consumer paths #623
Conversation
Provides dynamic consumer paths from generated URL using Consumer collection route. fixes chapter-three#615
@mglaman is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
I just noticed the failures, will fix |
Merged in |
Test needs consumers added to dependencies |
From the error log:
|
Ah, need to add to require-dev, which the current workflow may not do. I'll update to ensure the dependency is available during tests |
adds consumers to require dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still isn't right. It'll break at runtime without Conumers as a true dependency.
It should check if the module exists, then do
$variables += [
'authentication_bearer' => '# Authentication',
'DRUPAL_CLIENT_ID' => 'Retrieve this from ' . $path,
'DRUPAL_CLIENT_SECRET' => 'Retrieve this from ' . $path,
];
Provides dynamic consumer paths from generated URL using Consumer
collection route.
fixes #615
This pull request is for: (mark with an "x")
examples/*
modules/next
packages/next-drupal
starters/basic-starter
starters/graphql-starter
GitHub Issue: #615
Please add a link to the GitHub issue
where this problem is discussed.
Code changes need test coverage. If you don't know
how to make tests, check this box to ask for help.
Describe your changes
Uses the collection route name and generates the relative URL.