Introducing 'preview_enabled' on the next_entity_type_config entity #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bojanbogdanovic is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
bojanbogdanovic
force-pushed
the
preview-enabled
branch
from
f0439ad
to
5c0d143
Compare
|
This is working for us, and very much needed. Thanks @bojanbogdanovic! Here are the changes as a patch for the Next module in Drupal: |
|
Merge conflicts with a previous PR need to be resolved. Sorry about that! |
bojanbogdanovic
force-pushed
the
preview-enabled
branch
from
bebe744
to
c8f3000
Compare
|
Bump! Merge conflict is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterGitHub Issue: #496
Describe your changes
I have decoupled the site resolver from preview mode in the 'next_entity_type_config' and added a new 'preview_enabled' property. This property gives the ability to enable/disable the preview mode on specific entities. The site resolver is now also required, due the fact that it is needed for the preview mode and on demand revalidation.
Screenshot of the UI change:
