Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v2) improved keyboard enhancement detection #1283

Open
meowgorithm opened this issue Jan 8, 2025 · 0 comments
Open

(v2) improved keyboard enhancement detection #1283

meowgorithm opened this issue Jan 8, 2025 · 0 comments
Assignees
@aymanbagabas

Comments

@meowgorithm
Copy link
Member

We make two changes to the keyboard enhancement API for usability:

  • If keyboard enhancements are not supported the KeyboardEnhancementsMsg should still be sent through update via a reasonable but short timeout. The user can detect whether features are supported with the existing methods like KeyboardEnhancementsMsg.SupportsKeyReleases().
  • The EnableKeyboardEnhancements command should be renamed to RequestKeyboardEnhancements.
@aymanbagabas aymanbagabas mentioned this issue Jan 9, 2025
Merged
aymanbagabas added a commit that referenced this issue Jan 16, 2025
@aymanbagabas
chore: merge: keyboard enhancements msg, expose types and track reque…
4ed9c0a 
…sted and active enhancements (#1286)

refactor: keyboard: expose type and track requested and active
enhancements

This change exposes the `KeyboardEnhancements` type and tracks requested
and active enhancements in the `Program` struct. This change also
renames the `KeyboardEnhancement` type to `KeyboardEnhancementOption`
as well as`EnableKeyboardEnhancements` to `RequestKeyboardEnhancements`.



Fixes: #1283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aymanbagabas aymanbagabas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meowgorithm @aymanbagabas