From b661b869449cc97a302e7a644268a3bcef1e9f4e Mon Sep 17 00:00:00 2001 From: Ghislain Bourgeois Date: Fri, 5 May 2023 14:32:11 +0200 Subject: [PATCH] Use strictly confined snap --- src/charm.py | 5 ++++- tests/unit/test_charm.py | 9 ++++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/charm.py b/src/charm.py index 55fd199..db42556 100755 --- a/src/charm.py +++ b/src/charm.py @@ -148,7 +148,10 @@ def _on_remove_default_gw_action(self, event: ActionEvent) -> None: @staticmethod def _install_srsran() -> None: """Installs srsRAN snap.""" - shell("snap install srsran --edge --devmode") + shell("snap install srsran --edge") + shell("snap connect srsran:network-control") + shell("snap connect srsran:process-control") + shell("snap connect srsran:system-observe") logger.info("Installed srsRAN snap") @staticmethod diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py index 12a83d2..8360bd6 100644 --- a/tests/unit/test_charm.py +++ b/tests/unit/test_charm.py @@ -47,7 +47,14 @@ def test_given_unit_is_leader_when_on_install_then_srsran_snap_is_installed(self self.harness.charm.on.install.emit() - patch_shell.assert_called_with("snap install srsran --edge --devmode") + patch_shell.assert_has_calls( + [ + call("snap install srsran --edge"), + call("snap connect srsran:network-control"), + call("snap connect srsran:process-control"), + call("snap connect srsran:system-observe"), + ] + ) @patch("charm.shell", new=Mock()) def test_given_unit_is_leader_when_install_then_status_is_maintenance(self):