Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build MBQL from Python objects #25

Closed
wants to merge 14 commits into from
Closed

Build MBQL from Python objects #25

wants to merge 14 commits into from

Conversation

chasleslr
Copy link
Owner

Signed-off-by: Charles Larivier [email protected]

feat(mbql): add Query to compile MBQL
16c9184 
Signed-off-by: Charles Larivier <[email protected]>
@codecov
Copy link

codecov bot commented Feb 7, 2022 •
edited
Loading

Codecov Report

Merging #25 (806efae) into develop (4c236b4) will decrease coverage by 0.03%.
The diff coverage is 98.36%.

❗ Current head 806efae differs from pull request most recent head 903f5aa. Consider uploading reports for the commit 903f5aa to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #25      +/-   ##
===========================================
- Coverage    98.48%   98.45%   -0.04%     
===========================================
  Files           29       39      +10     
  Lines         1191     1426     +235     
===========================================
+ Hits          1173     1404     +231     
- Misses          18       22       +4
Impacted Files Coverage Δ
tests/resources/test_database.py 100.00% <ø> (ø)
src/metabase/mbql/filter.py 93.22% <93.22%> (ø)
src/metabase/__init__.py 100.00% <100.00%> (ø)
src/metabase/mbql/aggregations.py 100.00% <100.00%> (ø)
src/metabase/mbql/base.py 100.00% <100.00%> (ø)
src/metabase/mbql/groupby.py 100.00% <100.00%> (ø)
src/metabase/mbql/query.py 100.00% <100.00%> (ø)
tests/mbql/test_aggregations.py 100.00% <100.00%> (ø)
tests/mbql/test_base.py 100.00% <100.00%> (ø)
tests/mbql/test_filter.py 100.00% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d6c30a...903f5aa. Read the comment docs.

Charles Larivier added 4 commits February 22, 2022 23:00
feat: add Mbql
32bace6 
Signed-off-by: Charles Larivier <[email protected]>
feat: add aggregations.py
f662950 
Signed-off-by: Charles Larivier <[email protected]>
feat: add groupby.py
3d21436 
Signed-off-by: Charles Larivier <[email protected]>
feat: add filter.py
43f86fc 
Signed-off-by: Charles Larivier <[email protected]>
feat: add query.py
6036a29 
Signed-off-by: Charles Larivier <[email protected]>
@chasleslr chasleslr marked this pull request as ready for review February 23, 2022 14:23
This was linked to issues Feb 24, 2022
Add DatasetQuery #18
Open
Add support for name in Aggregation #30
Closed
Charles Lariviere added 3 commits February 23, 2022 22:45
fix: circular import
903f5aa 
Signed-off-by: Charles Lariviere <[email protected]>
@chasleslr chasleslr closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DatasetQuery Add support for name in Aggregation
1 participant
@chasleslr