-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Universal Developer Image as dev container #246
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
18043a1
to
da5eed6
Compare
Signed-off-by: Vitaliy Gulyy <[email protected]>
a380b9e
to
ac625d5
Compare
Signed-off-by: Vitaliy Gulyy <[email protected]>
There is one thing that needs to be fixed - is optimize the dev image as its size a bit huge
|
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@@ -6,81 +6,49 @@ | |||
# SPDX-License-Identifier: EPL-2.0 | |||
# | |||
|
|||
# https://quay.io/eclipse/che-machine-exec#^7\. | |||
FROM quay.io/eclipse/che-machine-exec:7.56.0 as machine-exec | |||
FROM quay.io/devfile/universal-developer-image:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
universal-developer-image
has a lot of tools, but as result it has a huge image size
is it really required to have all those tools from the universal-developer-image
for the che-code
development?
can we just add required tools to the dev image?
just for my understanding, as you are working on it and you know the problem better then me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some issues with configuring the podman in current che-dev
image.
So, It was much easier to take the universal developer image and add missing libraries, required for building vscode.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitaliy-guliy I believe the GitHub Workflow-related changes deserve a separate PR. As they are not directly related to the current PR. However, the current PR depends on these changes. We can review/test the GitHub Workflow simplification separately.
This pull request
Here I removed two existing jobs with messy logic (we discussed that) and added two separate independent jobs to build che-code and che-code-dev images. |
docker buildx build \ | ||
--platform linux/amd64 \ | ||
--progress=plain \ | ||
-f build/dockerfiles/linux-libc.Dockerfile \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the help of matrix strategy, you can combine Compile linux-libc
and Compile linux-musl
steps into just a single step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworked it intentionaly to prevent storing somewhere (uploading artifacts) the result of two launches of the build job.
Now we do not store artifacts. Now we build libc and musl, then build che-code image, upload it to quay.io and forget.
Pull Request Che-Code image published: |
Pull Request Dev image published: |
Pull Request Che-Code image published: |
Superseded by #253 |
What does this PR do?
What issues does this PR fix?
eclipse-che/che#22292
How to test this PR?
Do following:
yarn
che-code
image withpodman
Should have like following:
Note that:
all the 30 commits will be squashed when merging. I haven't squashed them here because of 1) all the commits to the branch were performed using online che-code, as for me the squashing it not clear UX flow; 2) do not want to add an extra commit as it triggers the github PR checks
at the moment,
quay.io/che-incubator-pull-requests/che-code-dev:pr-246-dev-amd64
is used as a dev image. I plan to update it after merging of this pull request and when the corresponding che-dev image will be built by the appropriate github action.