Use universal developer image for dev container #253
Conversation
vitaliy-guliy
requested review from
azatsarynnyy,
RomanNikitenko and
l0rd
as code owners
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
vitaliy-guliy
changed the title
|
@azatsarynnyy @RomanNikitenko could you please guys review this pull request and approve or deny it? |
| @@ -6,81 +6,49 @@ | |||
| # SPDX-License-Identifier: EPL-2.0 | |||
| # | |||
|
|
|||
| # https://quay.io/eclipse/che-machine-exec#^7\. | |||
| FROM quay.io/eclipse/che-machine-exec:7.56.0 as machine-exec | |||
| FROM quay.io/devfile/universal-developer-image:latest | |||
There was a problem hiding this comment.
@vitaliy-guliy
As I mentioned in your previous PR #246 (comment)
I don't think we should bring UDI for the Che-Code development
But in general it's OK for me to merge the current PR, if the changes look good for other reviewers
There was a problem hiding this comment.
The benefit of using UDI as the base image is that all UDI layers are already in the nodes of the cluster (especially if kube-image-puller is configured, so it should be really fast to pull images based on UDI on a kube cluster.
This comment was marked as outdated.
This comment was marked as outdated.
vitaliy-guliy
force-pushed
the
switch-to-udi-merge
branch
from
446b9dd to
fc445db
Compare
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
|
Pull Request Dev image published: |
|
@azatsarynnyy I cannot say for sure, but seems the terminal looks like as it was before
|
|
Pull Request Che-Code image published: |
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
|
Pull Request Dev image published: |
|
Pull Request Che-Code image published: |
Signed-off-by: Vitaliy Gulyy <[email protected]>
|
Pull Request Dev image published: |
Signed-off-by: Vitaliy Gulyy <[email protected]>
|
Pull Request Dev image published: |
|
Pull Request Che-Code image published: |
What does this PR do?
What issues does this PR fix?
eclipse-che/che#22292
How to test this PR?
Do following:
yarnche-codeimage withpodmanShould have like following:
Note that:
Depends on devfile/developer-images#117