Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check PR reviews action does not handle a pass being turning into a request for changes #79

Open
adcreare opened this issue Dec 12, 2024 · 0 comments
Assignees

Comments

@adcreare
Copy link
Contributor

The check PR review action is incorrectly marking something as able to be merged when it should.
The conditions for this are as follows:

  • PR with reviewer
  • Review PR and approve
  • Come back and then change review to request changes (add another review)
  • Action will pass, but shouldn't.

I think this is happening due to the review list being an array of reviews, we only check each reviewer has approved once. What we need to do is order the reviews by date and confirm that the last item is an approval. Care will need to be taken to ensure general comments after the approval are ok.

This probably should be fixed at the same time as #72

@adcreare adcreare self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant