You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The check PR review action is incorrectly marking something as able to be merged when it should.
The conditions for this are as follows:
PR with reviewer
Review PR and approve
Come back and then change review to request changes (add another review)
Action will pass, but shouldn't.
I think this is happening due to the review list being an array of reviews, we only check each reviewer has approved once. What we need to do is order the reviews by date and confirm that the last item is an approval. Care will need to be taken to ensure general comments after the approval are ok.
This probably should be fixed at the same time as #72
The text was updated successfully, but these errors were encountered:
The check PR review action is incorrectly marking something as able to be merged when it should.
The conditions for this are as follows:
I think this is happening due to the review list being an array of reviews, we only check each reviewer has approved once. What we need to do is order the reviews by date and confirm that the last item is an approval. Care will need to be taken to ensure general comments after the approval are ok.
This probably should be fixed at the same time as #72
The text was updated successfully, but these errors were encountered: