You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Delivery does not work correctly for git submodules. Since version 1.7.x, git, by default, absorbs .git directories from submodules into a modules folder within the parent .git directory leaving only a .git file containing the path to the .git directory
delivery init for example, instead of recognizing that the cwd is actually a git submodule from the .git file, present in the cwd, delivery walks into the parent directory to find a .git directory with a config file.
If the project root was correctly determined and the git remote add command was run from the correct directory, delivery would function with git submodules.
The text was updated successfully, but these errors were encountered:
Delivery does not work correctly for git submodules. Since version 1.7.x, git, by default, absorbs .git directories from submodules into a modules folder within the parent .git directory leaving only a .git file containing the path to the .git directory
Delivery, therefore cannot find the correct root based on the logic here:
https://github.com/chef/delivery-cli/blob/master/src/delivery/project/mod.rs#L178-L216
delivery init
for example, instead of recognizing that the cwd is actually a git submodule from the .git file, present in the cwd, delivery walks into the parent directory to find a .git directory with a config file.This, in turn, returns an incorrect project path, adds an incorrect remote path to the parent repo instead of adding the remote to the submodule as it's supposed to via:
https://github.com/chef/delivery-cli/blob/master/src/delivery/git/mod.rs#L294-L315
If the project root was correctly determined and the git remote add command was run from the correct directory, delivery would function with git submodules.
The text was updated successfully, but these errors were encountered: