Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for older nmr annotation format #6

Open
stropitek opened this issue Sep 29, 2016 · 0 comments
Open

Remove support for older nmr annotation format #6

stropitek opened this issue Sep 29, 2016 · 0 comments

Comments

@stropitek
Copy link
Contributor

We should avoid this kind of stuff:

if(options.format==="new"){

Is it really necessary? You shouldn't maintain two formats in the same code. Normally if the format changes you should create a major release of spectra-data and drop the old format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants