-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change of format #42
Comments
What does GC/MS/MS data look like? |
You have our normal view with GC and MS but you can click on some of the MS peaks (the main peaks of the MS) and you get the corresponding mass spectrum of this mass peak. |
Wouldn't it be better to have a Series3D class? |
I'm not asking how it looks like in an interface, but what how is the data (you only showed how you want the data to be for GC/MS in the original post) |
Indeed x/y object is not related to this problem. Data is indeed Series3D The format would look for 3D like:
And therefore would be compatible with the functions of Series2D. There would be only this new ms property. |
Today for series 2D we have
An array (the time) of array (2 values, mass, intensity) of array (the mass values and the intensity values).
I would like to change this to
This will allow me to add a third parameter (third dimension) that is in this case the msms. We have indeed mass spectra of GC / MS / MS
This would be of course a major release and will also require major release of jcampconverter and mzdata.
@targos Is this ok for you ?
@josoriom This should solve your problem as well.
The text was updated successfully, but these errors were encountered: