Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should be peak picking a method of common-spectrum or method specific? #1

Open
kjappelbaum opened this issue Jul 2, 2020 · 1 comment

Comments

@kjappelbaum
Copy link
Contributor

I started working a bit on the peak picking (https://github.com/kjappelbaum/xrd-analysis) but it seems to me that the code is not really dependent on the specific spectrum type (except for the peak shape). Maybe this should then be moved to common-spectrum?

What do you think @lpatiny ?

@lpatiny
Copy link
Member

lpatiny commented Jul 2, 2020

Maybe but for some spectra (like TGA) you can not make peak picking (except after derivative).
This is why I didn't put it there. But it is through that it could be in common spectrum and we don't need to export it in tga-spectrum for example. We can also when we reexport this method defined default parameter.
You may put it in common-spectrum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants