-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve /did/create API [DEV-3197] #388
Conversation
body in /did/create API.
/did/create API.
from "methodSpecificIdAlgo" to "identifierFormatType".
form based case.
in /did/create API.
/did/create API.
/create/did API.
body in /did/create API.
body in /did/create API.
- This always evaluates to truthy.
DidDocumentWithoutVerificationMethod type.
Task linked: DEV-3197 Improve /did/create API |
in /did/create API.
instead of helper functions.
request body in /did/create API.
/did/create API.
request body in /did/create API.
in did/create API.
in /did/create API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Approving + leaving validation, mutable declarations for future enhancements.
Thanks!
Merged DEV-3198 |
## [2.10.0-develop.1](2.9.4-develop.3...2.10.0-develop.1) (2023-10-16) ### Features * Improve /did/create API [DEV-3197] ([#388](#388)) ([9791dc6](9791dc6))
🎉 This PR is included in version 2.10.0-develop.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
methodSpecificIdAlgo
toidentifierFormatType
assertionMethod
service
as form-based (default to blank to skip)@context
(VerificationMethod
) as form-based one-of-many.key
to specify an existing key, either by key ID or by key alias (optional).didDocument
options
top-level property: Add:key
at the top level as optional, which can be used to specify an existing key ID or alias. Keep:verificationMethodType.
Use in conjunction with key above, or generate new.didDocument
, but this will be a partial DID Document (skip theverificationMethod
section since it will be generated based on two inputs above