Allow describe_voices of all languages

[DannyBen]

Maybe the available_voices_in method should not default to en-US?

Just calling Aws::Polly::Client.new.describe_voices without a language code provides all the voices in one call.

Also, perhaps rename the method to simply voices?

[chezou]

When I tried without language code, it couldn't work as well. And it seems the language code is required by reading API doc.

Did you try the described_voices without options? Could you show the result of it?

[DannyBen]

Yes, I tried before opening the issue. Maybe they improved it and you are running an older version of the SDK?

And actually, they seem to state that it is optional here:

"If you don't specify this optional parameter, all available voices are returned."

My #voices method looks like this:

def voices(lang=nil)
  client.describe_voices(language_code: lang).voices
end

When running:

pp Aws::Polly::Client.new.describe_voices
# Or even:
# pp Aws::Polly::Client.new.describe_voices language_code: nil

You get:

#<struct Aws::Polly::Types::DescribeVoicesOutput
 voices=
  [#<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Joanna",
    language_code="en-US",
    language_name="US English",
    name="Joanna">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Mizuki",
    language_code="ja-JP",
    language_name="Japanese",
    name="Mizuki">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Filiz",
    language_code="tr-TR",
    language_name="Turkish",
    name="Filiz">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Astrid",
    language_code="sv-SE",
    language_name="Swedish",
    name="Astrid">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Maxim",
    language_code="ru-RU",
    language_name="Russian",
    name="Maxim">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Tatyana",
    language_code="ru-RU",
    language_name="Russian",
    name="Tatyana">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Carmen",
    language_code="ro-RO",
    language_name="Romanian",
    name="Carmen">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Ines",
    language_code="pt-PT",
    language_name="Portuguese",
    name="Inês">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Cristiano",
    language_code="pt-PT",
    language_name="Portuguese",
    name="Cristiano">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Vitoria",
    language_code="pt-BR",
    language_name="Brazilian Portuguese",
    name="Vitória">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Ricardo",
    language_code="pt-BR",
    language_name="Brazilian Portuguese",
    name="Ricardo">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Maja",
    language_code="pl-PL",
    language_name="Polish",
    name="Maja">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Jan",
    language_code="pl-PL",
    language_name="Polish",
    name="Jan">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Ewa",
    language_code="pl-PL",
    language_name="Polish",
    name="Ewa">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Ruben",
    language_code="nl-NL",
    language_name="Dutch",
    name="Ruben">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Lotte",
    language_code="nl-NL",
    language_name="Dutch",
    name="Lotte">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Liv",
    language_code="nb-NO",
    language_name="Norwegian",
    name="Liv">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Giorgio",
    language_code="it-IT",
    language_name="Italian",
    name="Giorgio">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Carla",
    language_code="it-IT",
    language_name="Italian",
    name="Carla">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Karl",
    language_code="is-IS",
    language_name="Icelandic",
    name="Karl">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Dora",
    language_code="is-IS",
    language_name="Icelandic",
    name="Dóra">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Mathieu",
    language_code="fr-FR",
    language_name="French",
    name="Mathieu">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Celine",
    language_code="fr-FR",
    language_name="French",
    name="Céline">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Chantal",
    language_code="fr-CA",
    language_name="Canadian French",
    name="Chantal">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Penelope",
    language_code="es-US",
    language_name="US Spanish",
    name="Penélope">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Miguel",
    language_code="es-US",
    language_name="US Spanish",
    name="Miguel">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Enrique",
    language_code="es-ES",
    language_name="Castilian Spanish",
    name="Enrique">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Conchita",
    language_code="es-ES",
    language_name="Castilian Spanish",
    name="Conchita">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Geraint",
    language_code="en-GB-WLS",
    language_name="Welsh English",
    name="Geraint">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Salli",
    language_code="en-US",
    language_name="US English",
    name="Salli">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Kimberly",
    language_code="en-US",
    language_name="US English",
    name="Kimberly">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Kendra",
    language_code="en-US",
    language_name="US English",
    name="Kendra">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Justin",
    language_code="en-US",
    language_name="US English",
    name="Justin">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Joey",
    language_code="en-US",
    language_name="US English",
    name="Joey">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Ivy",
    language_code="en-US",
    language_name="US English",
    name="Ivy">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Raveena",
    language_code="en-IN",
    language_name="Indian English",
    name="Raveena">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Emma",
    language_code="en-GB",
    language_name="British English",
    name="Emma">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Brian",
    language_code="en-GB",
    language_name="British English",
    name="Brian">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Amy",
    language_code="en-GB",
    language_name="British English",
    name="Amy">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Russell",
    language_code="en-AU",
    language_name="Australian English",
    name="Russell">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Nicole",
    language_code="en-AU",
    language_name="Australian English",
    name="Nicole">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Marlene",
    language_code="de-DE",
    language_name="German",
    name="Marlene">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Hans",
    language_code="de-DE",
    language_name="German",
    name="Hans">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Naja",
    language_code="da-DK",
    language_name="Danish",
    name="Naja">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Mads",
    language_code="da-DK",
    language_name="Danish",
    name="Mads">,
   #<struct Aws::Polly::Types::Voice
    gender="Female",
    id="Gwyneth",
    language_code="cy-GB",
    language_name="Welsh",
    name="Gwyneth">,
   #<struct Aws::Polly::Types::Voice
    gender="Male",
    id="Jacek",
    language_code="pl-PL",
    language_name="Polish",
    name="Jacek">],
 next_token=nil>

[chezou]

Understood. I'm waiting for your PR :)