Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search field should not be auto-focused on mobile. #124

Closed
david-nyc-pm opened this issue Feb 20, 2024 · 3 comments · Fixed by #146
Closed

Search field should not be auto-focused on mobile. #124

david-nyc-pm opened this issue Feb 20, 2024 · 3 comments · Fixed by #146
Assignees
Labels
Character Finder Issues specific to the Character Finder tool enhancement New feature or request

Comments

@david-nyc-pm
Copy link

Description: On both desktop and mobile web, the curser automatically appears in the search bar upon entering the page. The actionable state is automatically enabled, which is noticeable as the outline of the box is currently "purple" by default when visiting the page. By having the curser default to the search bar, we are making assumptions that the first thing a user wants to do is use the search function. However, there are other ways a user can locate character info such as by tapping on the one of many tabs and/or scrolling through the list(s) of characters.

Expected result: Upon tapping the corresponding tab, user should be taken the Character Finder screen without the cursor immediately appearing in the search bar.

Screen Shot 2024-02-20 at 12 35 59 PM

@david-nyc-pm david-nyc-pm added enhancement New feature or request Character Finder Issues specific to the Character Finder tool labels Feb 20, 2024
@david-nyc-pm david-nyc-pm changed the title Cursor should not be in search box by default Cursor should not appear in search box/trigger the search box's actionable state by default Feb 20, 2024
@imadrig
Copy link
Contributor

imadrig commented Feb 20, 2024

Hi @david-nyc-pm, focusing the search bar on page load was a requested in response to a PR I submitted - PR #49. Has this requirement changed? @joekotvas could you provide more insight on whether this needs to be changed again?

@joekotvas
Copy link
Contributor

Hi @imadrig! I've conferred with @david-nyc-pm and the issue is that on mobile the keyboard pops up and covers half the screen when the tool loads. On desktop this is not an issue.

The solution we came up with is to only autofocus the search field on desktop.

@imadrig
Copy link
Contributor

imadrig commented Feb 20, 2024

Understood, thanks for clarifying!

@imadrig imadrig self-assigned this Feb 20, 2024
@joekotvas joekotvas changed the title Cursor should not appear in search box/trigger the search box's actionable state by default Search field should not be auto-focused on mobile. Feb 21, 2024
@joekotvas joekotvas linked a pull request Feb 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Character Finder Issues specific to the Character Finder tool enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants