Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to remove acquired skill #49

Closed
adilasif opened this issue Nov 7, 2018 · 4 comments
Closed

Unable to remove acquired skill #49

adilasif opened this issue Nov 7, 2018 · 4 comments
Labels
acquired_skills_selector new Suggestion for a new feature suggestion Suggestion for adding or changing a feature

Comments

@adilasif
Copy link

adilasif commented Nov 7, 2018

Unable to remove acquired skill - option does not exist (or can not be readily found). Option should exist in case of accidental addition of skill.

@tropicalchancer
Copy link

Thanks for reaching out @adilasif!

That's a great point. We'll add it to the backlog and let you know when it has been implemented. 🙏

@the-vampiire
Copy link
Contributor

Hey thanks for the suggestion. I have this implemented on the api but we’re still discussing how to display it to users.

I was picture an [x] on the side of the labels that you can click to remove. How would you like to see the feature implemented? Would a confirmation dialog on click be too annoying?

Sent with GitHawk

@adilasif
Copy link
Author

adilasif commented Nov 8, 2018

An [x] on the side that is only displayed when the user selects the edit option would be ideal, I think! I could go either way on the confirmation dialogue - in support of it, removing skills isn't a feature one would expect users to be using more than once or twice, and it's possible a user would click twice (thus removing two skills in succession) accidentally. On the other hand, adding skills is a matter of two seconds at most; in the event a user accidentally deletes one or more skills, it's not a real hassle to re-add them.

@the-vampiire the-vampiire added suggestion Suggestion for adding or changing a feature new Suggestion for a new feature acquired_skills_selector labels Nov 11, 2018
@the-vampiire
Copy link
Contributor

Issue moved to chingu-x/chingu-frontend #164 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acquired_skills_selector new Suggestion for a new feature suggestion Suggestion for adding or changing a feature
Projects
None yet
Development

No branches or pull requests

3 participants