Include all files in the variants folder for compiling. #588

ricklon · 2015-08-20T23:37:17Z

Include all files in the variants folder for compiling. This the better way to do that.

  if (variantFolder != null)
      objectFiles.addAll(compileFiles(buildFolder, variantFolder, true,
                                      includeFolders));

The text was updated successfully, but these errors were encountered:

EmbeddedMan · 2015-10-21T14:11:08Z

Rick, where should this line go? At the very top of compileSketch() in Compiler.java?

ricklon · 2015-10-21T14:29:17Z

I'll check. Will have feedback tonight.

--Rick

On Wed, Oct 21, 2015 at 10:11 AM, Brian Schmalz [email protected]
wrote:

Rick, where should this line go? At the very top of compileSketch() in
Compiler.java?

—
Reply to this email directly or view it on GitHub
#588 (comment)
.

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

EmbeddedMan · 2015-10-22T00:16:11Z

Rick - I think this is the last major MPIDE 'bug' to squash before it will compile the blink sketch for all boards.

ricklon · 2015-10-22T02:43:40Z

variant folder is found in this code

    if (variant != null) {
            if (variant.indexOf(':') == -1) {
                Target t = Base.getTarget();
                variantPath = t.getVariantFolder(variant).getAbsolutePath();
            } else {
                Target t = Base.targetsTable.get(variant.substring(0,
variant.indexOf(':')));
                variantPath = t.getVariantFolder(variant).getAbsolutePath();
            }
        }

        logger.debug("Variant Path: " + variantPath);

On Wed, Oct 21, 2015 at 8:16 PM, Brian Schmalz [email protected]
wrote:

Rick - I think this is the last major MPIDE 'bug' to squash before it will
compile the blink sketch for all boards.

—
Reply to this email directly or view it on GitHub
#588 (comment)
.

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

ricklon · 2015-10-22T02:45:13Z

It's stuffed inside this variable: includePaths

compileSketch(avrBasePath, buildPath, includePaths, configPreferences);

On Wed, Oct 21, 2015 at 10:43 PM, Rick Anderson <[email protected]

wrote:

variant folder is found in this code
    if (variant != null) {
            if (variant.indexOf(':') == -1) {
                Target t = Base.getTarget();
                variantPath =
t.getVariantFolder(variant).getAbsolutePath();
            } else {
                Target t = Base.targetsTable.get(variant.substring(0,
variant.indexOf(':')));
                variantPath =
t.getVariantFolder(variant).getAbsolutePath();
            }
        }

        logger.debug("Variant Path: " + variantPath);
On Wed, Oct 21, 2015 at 8:16 PM, Brian Schmalz [email protected]
wrote:

Rick - I think this is the last major MPIDE 'bug' to squash before it
will compile the blink sketch for all boards.

—
Reply to this email directly or view it on GitHub
#588 (comment)
.

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

ricklon · 2015-10-22T02:48:05Z

Then these files are searched for and added .c, .cpp, .S compiled in.

this.objectFiles.addAll(compileFiles(avrBasePath, buildPath, includePaths,
findFilesInPath(buildPath, "S", false),
findFilesInPath(buildPath, "c", false),
findFilesInPath(buildPath, "cpp", false),
configPreferences));

But it looks for "buildPath" in this portion of code.

--RIck

On Wed, Oct 21, 2015 at 10:44 PM, Rick Anderson <[email protected]

wrote:

It's stuffed inside this variable: includePaths
compileSketch(avrBasePath, buildPath, includePaths, configPreferences);
On Wed, Oct 21, 2015 at 10:43 PM, Rick Anderson <
[email protected]> wrote:
variant folder is found in this code
    if (variant != null) {
            if (variant.indexOf(':') == -1) {
                Target t = Base.getTarget();
                variantPath =
t.getVariantFolder(variant).getAbsolutePath();
            } else {
                Target t = Base.targetsTable.get(variant.substring(0,
variant.indexOf(':')));
                variantPath =
t.getVariantFolder(variant).getAbsolutePath();
            }
        }

        logger.debug("Variant Path: " + variantPath);
On Wed, Oct 21, 2015 at 8:16 PM, Brian Schmalz [email protected]
wrote:

Rick - I think this is the last major MPIDE 'bug' to squash before it
will compile the blink sketch for all boards.

—
Reply to this email directly or view it on GitHub
#588 (comment)
.

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org
Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

EmbeddedMan · 2015-10-22T02:50:48Z

Rick,

Right, but I don't see how to get all of the files in the variant folder to
compile. Your initial code snippit doesn't compile.

Brian
On Oct 21, 2015 9:45 PM, "Ricklon" [email protected] wrote:

It's stuffed inside this variable: includePaths
compileSketch(avrBasePath, buildPath, includePaths, configPreferences);
On Wed, Oct 21, 2015 at 10:43 PM, Rick Anderson <
[email protected]
wrote:

variant folder is found in this code
if (variant != null) {
if (variant.indexOf(':') == -1) {
Target t = Base.getTarget();
variantPath =
t.getVariantFolder(variant).getAbsolutePath();
} else {
Target t = Base.targetsTable.get(variant.substring(0,
variant.indexOf(':')));
variantPath =
t.getVariantFolder(variant).getAbsolutePath();
}
}

logger.debug("Variant Path: " + variantPath);
On Wed, Oct 21, 2015 at 8:16 PM, Brian Schmalz <[email protected]

wrote:

Rick - I think this is the last major MPIDE 'bug' to squash before it
will compile the blink sketch for all boards.

—
Reply to this email directly or view it on GitHub
<
#588 (comment)

.

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org
Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

—
Reply to this email directly or view it on GitHub
#588 (comment)
.

ricklon · 2015-10-22T02:59:23Z

So it finally drills down to:

private List<File> compileFiles(String avrBasePath,
String buildPath,
ArrayList<String> includePaths,
List<File> sSources, List<File>
cSources,
List<File> cppSources,
HashMap<String, String> configPreferences) throws RunnerException {

List<File> objectPaths = new ArrayList<File>();

for (File file : sSources) {
String objectPath = buildPath + File.separator + file.getName()
+ ".o";
objectPaths.add(new File(objectPath));
execAsynchronously(getCommandCompilerS(avrBasePath, includePaths,
file.getAbsolutePath(), objectPath, configPreferences));
}

for (File file : cSources) {
String objectPath = buildPath + File.separator + file.getName()
+ ".o";
objectPaths.add(new File(objectPath));
execAsynchronously(getCommandCompilerC(avrBasePath, includePaths,
file.getAbsolutePath(), objectPath, configPreferences));
}

for (File file : cppSources) {
String objectPath = buildPath + File.separator + file.getName()
+ ".o";
objectPaths.add(new File(objectPath));
execAsynchronously(getCommandCompilerCPP(avrBasePath, includePaths,
file.getAbsolutePath(), objectPath, configPreferences));
}

return objectPaths;
}

On Wed, Oct 21, 2015 at 10:50 PM, Brian Schmalz [email protected]
wrote:

Rick,

Right, but I don't see how to get all of the files in the variant folder to
compile. Your initial code snippit doesn't compile.

Brian
On Oct 21, 2015 9:45 PM, "Ricklon" [email protected] wrote:
It's stuffed inside this variable: includePaths
compileSketch(avrBasePath, buildPath, includePaths, configPreferences);
On Wed, Oct 21, 2015 at 10:43 PM, Rick Anderson <
[email protected]
wrote:

variant folder is found in this code
if (variant != null) {
if (variant.indexOf(':') == -1) {
Target t = Base.getTarget();
variantPath =
t.getVariantFolder(variant).getAbsolutePath();
} else {
Target t = Base.targetsTable.get(variant.substring(0,
variant.indexOf(':')));
variantPath =
t.getVariantFolder(variant).getAbsolutePath();
}
}

logger.debug("Variant Path: " + variantPath);
On Wed, Oct 21, 2015 at 8:16 PM, Brian Schmalz <
[email protected]

wrote:

Rick - I think this is the last major MPIDE 'bug' to squash before it
will compile the blink sketch for all boards.

—
Reply to this email directly or view it on GitHub
<
#588 (comment)

.

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

—
Reply to this email directly or view it on GitHub
<
#588 (comment)

.
—
Reply to this email directly or view it on GitHub
#588 (comment)
.

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

… variants folder.

…s folder.

EmbeddedMan · 2015-10-30T16:42:22Z

I can confirm that this works as WiFire is now building without compile errors.

ricklon added the compile process label Aug 21, 2015

EmbeddedMan assigned ricklon Oct 24, 2015

ricklon added a commit to ricklon/chipKIT32-MAX that referenced this issue Oct 29, 2015

Issue chipKIT32#588 updated Compiler.java to compile all files in the…

ee20933

… variants folder.

ricklon mentioned this issue Oct 29, 2015

Fixes issue #588 compile files in variant folder #628

Closed

ricklon added a commit that referenced this issue Oct 29, 2015

Issue #588 updated Compiler.java to compile all files in the variant…

45de609

…s folder.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include all files in the variants folder for compiling. #588

Include all files in the variants folder for compiling. #588

ricklon commented Aug 20, 2015

EmbeddedMan commented Oct 21, 2015

ricklon commented Oct 21, 2015

EmbeddedMan commented Oct 22, 2015

ricklon commented Oct 22, 2015

ricklon commented Oct 22, 2015

ricklon commented Oct 22, 2015

EmbeddedMan commented Oct 22, 2015

ricklon commented Oct 22, 2015

EmbeddedMan commented Oct 30, 2015

Include all files in the variants folder for compiling. #588

Include all files in the variants folder for compiling. #588

Comments

ricklon commented Aug 20, 2015

EmbeddedMan commented Oct 21, 2015

ricklon commented Oct 21, 2015

EmbeddedMan commented Oct 22, 2015

ricklon commented Oct 22, 2015

ricklon commented Oct 22, 2015

ricklon commented Oct 22, 2015

EmbeddedMan commented Oct 22, 2015

ricklon commented Oct 22, 2015

EmbeddedMan commented Oct 30, 2015