Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUT-thru tests #87

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

mkurc-ant
Copy link
Collaborator

This PR adds a new test architecture testarch_nolutff which requires the use of LUT-thrus for FF inputs.

@mkurc-ant mkurc-ant force-pushed the testarch-noffmux branch 2 times, most recently from 7bf1b2a to ce7de7f Compare December 2, 2021 08:42
Copy link
Contributor

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one minor comment

@@ -0,0 +1,14 @@
generate_testarch_device_db(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we may want to generate different test architectures to test different features, we may want to put all of them under a testarchs directory?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. But this change requires chipsalliance/python-fpga-interchange#143

Copy link
Contributor

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a small fix

tests/tests.cmake Outdated Show resolved Hide resolved
Copy link
Contributor

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants