-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve series functionality #432
Open
Tekki
wants to merge
5
commits into
chipzoller:master
Choose a base branch
from
Tekki:show-related
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am adhering to the Developer Certificate of Origin. |
Resolves chipzoller#430. Signed-off-by: Tekki <[email protected]>
Signed-off-by: Tekki <[email protected]>
Signed-off-by: Tekki <[email protected]>
I know this is so late, @Tekki, but could you resolve conflicts here so we can try and get it in? |
Signed-off-by: Tekki <[email protected]>
Signed-off-by: Tekki <[email protected]>
chipzoller
reviewed
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Requesting a review from @onweru here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
Current state
Closes #430
Proposed changes
The PR consists of 3 commits:
Correction of the
series
entries in the example site;series
is a single value, not an array.Changes at the code. The entries in
params.toml
by the original author of the series functionalitysuggest that the default value of this variables is
false
. The code should behave accordingly.Then I thought it could be useful if both variables can be overridden in a post.
Screenshots, if applicable
Checklist
git commit -s ...
), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.