-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGMIX does not include entropy of mixing #92
Comments
This one has led to failures in our test suite for air entropy. Those tests were all based on PM-generated reference states just to monitor changes to code. I will update those reference values in the test suite. Do you have the entropy calculation "finalized" in the igtools branch, or should I hang tight for that one? This raises a good question though of whether we have an external reference for air entropies that we could refer to rather than just ensuring the internal consistency? |
…l iteration so that we yield correct values when adding it back on later. Relevant for fixing issues raised during the revisions to allow for #92.
Alright, there are two separate branches I added from the
There are a number of tests that fail, meaning there were bugs, so the branch |
I've pushed my fixes to the master branch as v2.2.5 with the intention of letting it serve as a beta release. I figured it would break the test code since these features are fundamentally dissimilar to the historical behavior, so I used my typical manual command-line tests to confirm that the mixtures are working correctly. I'll hold back an update of the python package index until we've had a chance to talk in more detail. |
Users should be aware that igmix does not correctly add the "entropy of mixing" to its calculations. This winds up being a constant added to all entropy calculations. It will not affect the results of any engine or cycle calculations for the reasons already described in the FAQ. However, users doing mixture work might notice some small discrepancies (e.g. about 2% for atmospheric temperature air).
As of version v2.2.4, if users are doing work with variable gas mixtures, it probably doesn't make sense to use the igmix class anyway, since it only allows static mixtures. On the other hand, if mixtures are constant, then the offset will not be important either. That's probably why this has never been a problem.
The entropy of mixing term will be added correctly in the next release, which may cause a small change in igmix class entropy values, but should not affect any cycle calculations.
The text was updated successfully, but these errors were encountered: