Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add checking for out-of-range values when looking up parish IDs? #44

Open
hepplerj opened this issue Jul 21, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@hepplerj
Copy link
Member

Just something I'm considering: right now, the new BOM endpoints allow users to return a set of data based on a Parish ID, so a specific parish can be chosen from the data. Currently, if a Parish ID is selected that's outside the range of available values it simply returns an empty array. But we may want to handle this differently as a bad request instead.

@hepplerj hepplerj self-assigned this Jul 21, 2022
@lmullen
Copy link
Member

lmullen commented Jul 22, 2022

In case it is useful, here is an example of doing that.

https://github.com/chnm/apiary/blob/main/ahcb.go#L48

@hepplerj
Copy link
Member Author

hepplerj commented Jul 22, 2022

Thanks @lmullen -- that's precisely what I had in mind, it's helpful to see a working example. I'll get that added, plus update my tests, next week.

@hepplerj hepplerj added enhancement New feature or request question Further information is requested labels Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants