Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST max temperature from CLI #1195

Open
ijpulidos opened this issue May 18, 2023 · 2 comments · May be fixed by #1197
Open

REST max temperature from CLI #1195

ijpulidos opened this issue May 18, 2023 · 2 comments · May be fixed by #1197

Comments

@ijpulidos
Copy link
Contributor

Currently perses REST capabilities are not being used in the small molecule pipeline from CLI. One quick way to do this is passing a configuration option from the YAML file to be used as t_max when setting up the sampler in

hss[phase].setup(n_states=n_states, n_replicas=n_replicas, temperature=temperature,

This would allow sampling using REST in the small molecule pipeline, which might be something that we would like to have and experiment with in the near future.

@ijpulidos
Copy link
Contributor Author

We should do the same validation as we do with the other parameters here

def _generate_htf(phase: str, topology_proposal_dictionary: dict, setup_options: dict):

@zhang-ivy
Copy link
Contributor

We can write a test that checks that the rest lambda values are changing (and between 0 and 1) when we use T_max != 300 K. We can do this by checking state.lambda_rest_bonds where state is one of the non-endstate thermodynamic states (i.e. a state with lambda > 0 or < 1)..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants