Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add an ability to use OpenAI / VoyageAI / Cohere embeddings with SDPMChunker via LiteLLM #38

Open
rodion-m opened this issue Nov 18, 2024 · 5 comments · May be fixed by #154
Open
Assignees
Labels
enhancement New feature or request

Comments

@rodion-m
Copy link

rodion-m commented Nov 18, 2024

We can make something line EmbeddingsProvider abstraction with many implementations like SentenceTransformerEmbeddingsProvider, LiteLlmEmbeddingsProvider, FastEmbedEmbeddingsProvider and so on.

@rodion-m rodion-m added the enhancement New feature or request label Nov 18, 2024
@rodion-m
Copy link
Author

@bhavnicksm could you please try to add this project into Copilot Workspace and try to implement this issue with it? I believe that it should solve it.

@bhavnicksm
Copy link
Collaborator

Hey @rodion-m !

Thanks for opening an issue 😊

Yes! That's the plan, we have a BaseEmbeddings class, that we built to make initial embeddings support for Chonkie 🙌

Some things remaining to plan out is the integration and refactor for Chunkers to use BaseEmbeddings and default Embeddings initialisation scheme...

Planning to continue support for SentenceTransformers as the default but also make it so that a str input inside chunkers could be supported for the users to avoid having too bulky inits on the API side...

Happy to accept comments and PRs for this!

Thanks

@rodion-m
Copy link
Author

Yeah, thanks a lot for your work and for a great library. It's great that it's universal and not linked to LangChain / LlamaIndex.

@bhavnicksm
Copy link
Collaborator

Yeah, thanks a lot for your work and for a great library. It's great that it's universal and not linked to LangChain / LlamaIndex.

Thank you so much! Appreciate the kind words :)

@bhavnicksm
Copy link
Collaborator

@bhavnicksm could you please try to add this project into Copilot Workspace and try to implement this issue with it? I believe that it should solve it.

Yeah, I'll try with Copilot workspace... Till now, I've had a slightly negative experience where it would introduce some bugs that I would need to fix later on. So I'm a bit careful with it, taking only suggestions from copilot and not full PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants