Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note recording broken for custom scale #5

Open
evguu opened this issue Jun 1, 2024 · 1 comment
Open

Note recording broken for custom scale #5

evguu opened this issue Jun 1, 2024 · 1 comment

Comments

@evguu
Copy link

evguu commented Jun 1, 2024

Custom scale requires special handling, which was forgotten in some places.
Examples:

const scale: ReadonlyArray<boolean> = Config.scales[this._doc.song.scale].flags;

Missing handling causes incorrect note recording prompt layout for custom scale.

const scaleFlags: ReadonlyArray<boolean> = Config.scales[doc.song.scale].flags;

Missing handling causes note recording to always use the default setup of the scale, ignoring what the user has set.

@choptop84
Copy link
Owner

Both of these files are nearly identical to UltraBox, so either the issue is found elsewhere or UltraBox also has this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants