Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example sitefox/examples/nbb missing dependencies in package.json #43

Open
jasalt opened this issue Feb 21, 2025 · 1 comment
Open

Example sitefox/examples/nbb missing dependencies in package.json #43

jasalt opened this issue Feb 21, 2025 · 1 comment

Comments

@jasalt
Copy link

jasalt commented Feb 21, 2025

  • Sitefox version c615c0a
  • nodejs version: v18.19.0 (Debian 12)
  • npm version: 10.4.0

While getting the example sitefox/examples/nbb running I had to install bunch of packages manually that were not included in example package.json:

diff --git a/examples/nbb/package.json b/examples/nbb/package.json
index 35b686a..f6f089e 100644
--- a/examples/nbb/package.json
+++ b/examples/nbb/package.json
@@ -1,9 +1,20 @@
 {
   "dependencies": {
+    "cookie-parser": "^1.4.7",
+    "csrf-csrf": "^3.1.0",
+    "express": "^4.21.2",
+    "express-session": "^1.18.1",
     "filewatcher": "^3.0.1",
+    "json-stringify-safe": "^5.0.1",
+    "keyv": "^5.2.3",
+    "morgan": "^1.10.0",
     "nbb": "^1.2.179",
+    "node-html-parser": "^7.0.1",
+    "passport": "^0.7.0",
+    "passport-local": "^1.0.0",
     "react": "^17.0.2",
     "react-dom": "^17.0.2",
+    "rotating-file-stream": "^3.2.6",
     "sitefox": "file:../../"
   },
   "scripts": {

After this server started with "Hello world!".

EDIT: split latter part into another issue. I use old distro NodeJS/npm versions, not sure if related.

@jasalt jasalt changed the title Examples with nbb are missing dependencies Example sitefox/examples/nbb missing dependencies in package.json Feb 21, 2025
@jasalt
Copy link
Author

jasalt commented Feb 22, 2025

Other nbb examples I tried seem to have same issue:

  • sitefox/examples/nbb-auth
  • sitefox/examples/form-validation
  • sitefox/examples/templates

Shadow-cljs example sitefox/examples/authentication starts as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant