Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook name should be newrelic_ng #28

Open
chr4 opened this issue Aug 13, 2014 · 3 comments
Open

Cookbook name should be newrelic_ng #28

chr4 opened this issue Aug 13, 2014 · 3 comments

Comments

@chr4
Copy link
Member

chr4 commented Aug 13, 2014

Convenction is afaik that cookbooks should prefer _ over -. This might be changed in a future version.

@ofir-petrushka
Copy link
Contributor

Doing this would be a breaking change, assuming attributes are going to get renamed...
Is it worth it?.. Will anyone gain anything from this? is the gain worth the pain for all users updating their cookbooks/recipes?..

@chr4
Copy link
Member Author

chr4 commented Jul 1, 2016

Yeah, this is not going to happen soon - Maybe when releasing a next major release with breaking changes.

@jeffbyrnes
Copy link
Contributor

I’d say it’s alright, considering build-essential is still named with a hyphen. It is best practice to use underscores nowadays, but I think you can leave it alone & avoid the serious pain this would bring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants