Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support lables in php agent #32

Open
ofir-petrushka opened this issue Jun 22, 2016 · 2 comments
Open

Feature Request: Support lables in php agent #32

ofir-petrushka opened this issue Jun 22, 2016 · 2 comments

Comments

@ofir-petrushka
Copy link
Contributor

Support application level labels.

"newrelic.labels" @
https://docs.newrelic.com/docs/agents/php-agent/configuration/php-agent-configuration

(probably relevant for other languages as well)

@ofir-petrushka ofir-petrushka changed the title Support lables in php agent Feature Request: Support lables in php agent Jun 22, 2016
@chr4
Copy link
Member

chr4 commented Jun 22, 2016

@jeffbyrnes contributed the php-agent code. Jeff, interested in contributing once more? :)

@jeffbyrnes
Copy link
Contributor

@chr4 @ofir-petrushka unfortunately, I don’t have any cycles to help out with this right now.

I took a quick look through the code, and I’d suggest, whether it’s me or somebody else, refactoring the resources to be more future-proof, and allow an operator to pass in a hash of config values that’s directly translated to the config format. That way, we avoid having to keep up with changes New Relic makes with a 1:1 relationship of resource attributes/properties and cookbook attributes.

I just finished a refactor of the zookeeper cookbook, going from LWRPs to Chef 12.5 Custom Resources, and its zookeeper_config resource works in this fashion (see v7.0.0 @ lines 23–27 of config.rb).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants