fix: Include simde in Pgenlib python package, fixing aarch64 build #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l be available when compiling. This will fix Pgenlib on both Mac aarch64 and Linux aarch64, its broken in both right now.
…ers from a previous version.
|
I went ahead and made a workflow to build mac ARM wheels: #262 as an excuse to learn about cibuildwheel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, since I noticed a problem with the Pgenlib python package, I might as well fix it.
Add src/plink2/simde directory to the Python package such that it will be available when compiling. This will fix Pgenlib on both Mac aarch64 and Linux aarch64, its broken in both right now.
I noticed that there were old
includelines inMANIFEST.infrom when simde headers used to live directly ininclude. I have removed those, they did not match any files and were not doing anything.I followed your pattern of including specific files rather than using
recursive-include, but recursive-include would certainly make a simpler, maybe more robust MANIFEST.in.This should fix #260. I have tested it on a Raspberry Pi 4 to check
aarch64-linux-gnuP.S. I don't know what kind of CI you use to build Pgenlib, but I'd be glad to help you make it produce aarch64 wheels as well. ARM market share is increasing significantly, and it's the best value available on AWS.