Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the color and the highlighting #7

Open
zhanzhenzhen opened this issue Mar 8, 2012 · 3 comments
Open

the color and the highlighting #7

zhanzhenzhen opened this issue Mar 8, 2012 · 3 comments

Comments

@zhanzhenzhen
Copy link

Hi, I found some issues:

  1. The "coffee.this" color looks too light. Sometimes it's hard to recognize the text. I suggest using rgb(192,96,0) or just black.
  2. There are 2 issues in the parenthesis highlighting. First, if the ")" is the last character of the file, it will not be highlighted when you move the caret on it. Second, if you type:
    s.replace(///"///, """)
    or
    s.replace(///'///, "'")
    Even if it's not the last character of the file, the ")" will not be highlighted. That may be because of the quotation (apostrophe) mark in the regular expression.
  3. Just a suggestion: In Microsoft's JavaScript editor, some "value" keywords such as null, undefined, true and false are in black color. Could you use this style?
@zhanzhenzhen
Copy link
Author

Ah, I'm wrong. In javascript only the keyword "undefined" is in black color.

@zhanzhenzhen
Copy link
Author

I have another suggestion:
Consider this string:
"abc def #{example1} #{example2} ghi"
If you could make it recognize the "#{example1}" and "#{example2}" and make them in black color instead of the dark red, it will be better.

@chrisdunelm
Copy link
Owner

Thanks for letting me know about this issue - I think you are correct that it doesn't handle regex's correctly.

I agree that it would be good to support syntax highlighting #{...}'s in strings.

I'll see if I can find time to make these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants