Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget.exe push behaving differently pushing to Klondike v2.1.1 after upgrade from v.1.6.2 #191

Open
RyPhi76 opened this issue May 31, 2017 · 4 comments

Comments

@RyPhi76
Copy link

RyPhi76 commented May 31, 2017

I have a database build that yields four .nupkg packages.

Three of them get pushed to our new v.2.1.1 Klondike server with no issues but one package, named Database.Patch.version.nupkg, keeps getting converted to a *.symbols.nupkg package and pushed to the symbols folder.

The same Nuget push command pointing to our old v.1.6.2 Klondike server behaves correctly placing the package in the packages folder.

I am able to manually execute the Nuget Push from the command line from our [TeamCity] Build Agent server and continually encounter the same issue.

I have tried using Nuget version 3.1, 3.5, and 4.1.

I have also specified the -NoSymbols argument all to no avail.

I presume there is something in the contents of the package that is triggering this to occur but I can't seem to identify it. I had thought it was the presence of .pdb files but I have .pdb files in other packages that are pushing just fine.

We don't use symbols at all whatsoever.

Any assistance troubleshooting this would be great.

Thank you,
Ryan P

@lukeskinner
Copy link

https://github.com/themotleyfool/NuGet.Lucene/blob/bfb950418a939fab5183dcc0c0136a2e1e7e3df5/source/NuGet.Lucene/Util/PackageExtensions.cs

        public static bool HasSourceAndSymbols(this IPackage package)
        {
            var hasSymbols = package.GetFiles()
                .Any(pf => string.Equals(Path.GetExtension(pf.Path), ".pdb",
                    StringComparison.InvariantCultureIgnoreCase));

            return hasSymbols && package.GetFiles("src").Any();
        }

My first guess would be this method that's causing the problem. It's called when you upload a package - if it returns true it will redirect the upload to the symbols service.

Check if you have a 'src' folder at the root of your NuGet package.

@chriseldredge
Copy link
Owner

Here's some background on this problem: http://chris.eldredge.io/blog/2015/01/05/nuget-symbols-and-aspnet-vnext/.

I'm not working on Klondike actively, but still willing to maintain the project and merge PRs.

@RyPhi76
Copy link
Author

RyPhi76 commented Jun 1, 2017 via email

@RyPhi76
Copy link
Author

RyPhi76 commented Jun 2, 2017

Thanks @chriseldredge and @lukeskinner! I omitted the /src folder within the .nuspec and this issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants