Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify in documentation that Nice Names must be URL-encoded #38

Open
unitof opened this issue Oct 4, 2016 · 0 comments
Open

Specify in documentation that Nice Names must be URL-encoded #38

unitof opened this issue Oct 4, 2016 · 0 comments

Comments

@unitof
Copy link

unitof commented Oct 4, 2016

I am using git to push webapp changes to a simple HTTP staging server, so I wanted the nice-name in Slack to conveniently link to the new live changes. I tried setting hooks.slack.repo-nice-name to the URL of my staging server but that broke the app (it wouldn't send anything on post-receive).

But! I just discovered that URL-encoding the nice-name works perfectly, and Slack (or some other step in the API chain) conveniently URL-decodes it as well.

For example:
git config hooks.slack.repo-nice-name 'http://127.0.0.1/path/to/page.html' does not work.
git config hooks.slack.repo-nice-name 'http%3A%2F%2F127.0.0.1%2Fpath%2Fto%2Fpage.html' works perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant