Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Aesthetics ] Disable Top bar button adjustment #488

Open
JorgeR81 opened this issue Jan 8, 2025 · 4 comments
Open

[ Aesthetics ] Disable Top bar button adjustment #488

JorgeR81 opened this issue Jan 8, 2025 · 4 comments

Comments

@JorgeR81
Copy link

JorgeR81 commented Jan 8, 2025

The Controller's Top bar buttons are adjusted, when we add more workflow tabs.

c0

This was good feature, but now it's not necessary anymore, because in the latest frontend we can scroll workflow tabs:

Now all workflow tabs are always in the same row, so the button adjustment only results in a thicker bar.

c3

c2

c1

@JorgeR81
Copy link
Author

With the latest frontend ( 1.7.7 ), this is even more necessary, because the Topbar has a fixed height:

So now, it looks like this:

r11

@jeery-star
Copy link

The design is not reasonable, can not adapt to the screen, really do not know what the designer has in mind, anti-human design

@chrisgoringe
Copy link
Owner

chrisgoringe commented Jan 20, 2025 via email

@JorgeR81
Copy link
Author

JorgeR81 commented Jan 20, 2025

The design is not reasonable, can not adapt to the screen, really do not know what the designer has in mind, anti-human design

I think this refers to the Topbar's fixed height, since the same comment it's in that PR

But the fixed height PR was introduced in conjunction with a PR for scrolling tabs ( see first comment ), and another PR for tabs in the 2nd row ( see the previous issue ), so I think overall it was a good improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants