Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Ensure that code is formatted before publish CI #16

Closed
samjowen opened this issue May 5, 2024 · 2 comments
Closed

Proposal: Ensure that code is formatted before publish CI #16

samjowen opened this issue May 5, 2024 · 2 comments

Comments

@samjowen
Copy link
Contributor

samjowen commented May 5, 2024

Hi @chrisgreg , seeing as this is a repository that shares common goals with shadcn's library — code ownership for the users, I think it would be a good idea to ensure that the code in this repository is always formatted before publishing.

Therefore, I propose adding a CI step that looks something like this as part of the build or publish job:

      # Step: Check that the checked in code has already been formatted.
      # This step fails if something was found unformatted.
      - name: Check Formatting
        run: mix format --check-formatted

What do you think?

@chrisgreg
Copy link
Owner

Sounds great, spin up a PR :)

@chrisgreg
Copy link
Owner

Closed by #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants