Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize .html and .txt urls #176

Closed
magicmark opened this issue Aug 20, 2024 · 5 comments · Fixed by #177
Closed

normalize .html and .txt urls #176

magicmark opened this issue Aug 20, 2024 · 5 comments · Fixed by #177

Comments

@magicmark
Copy link

for big json dumps, loading the page can take forever and crash the browser, and i usually just want to curl it anyway

but if folks provide me the .html page, i can't easily map to the .txt url

could they share the same id in the url?

@magicmark
Copy link
Author

i see the comment from here #62 (comment) which makes sense, but somewhere in def upload(): can we generate an id and share it with the plaintext and html file in s3?

@chriskuehl
Copy link
Owner

chriskuehl commented Aug 20, 2024

I think we could make the HTML and TXT files have the same name (other than extension of course).

Just to be clear, technically an upload can produce multiple HTML files and TXT files. For example https://i.fluffy.cc/PPMCfvrXGF1fhGWjs6lKqfLn21xHB7HB.html has five files (not counting the JSON files):

If the file1 txt+html and the file2 txt+html had the same name, that would do what you want?

@magicmark
Copy link
Author

heck yeah!

Screenshot 2024-08-20 at 4 11 46 PM

so 'direct link' and 'view text' would be the same url, apart from the suffix

@chriskuehl
Copy link
Owner

I think #177 will do it. I'm traveling at the moment but I'll test this more thoroughly and merge it soon.

@chriskuehl
Copy link
Owner

Released in v1.40.0.

Here's an example on the new version: https://i.fluffy.cc/pLRkPrVHQdjqXg5697pwcncxs3VG9Bkv.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants