-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does this work with html storybooks? #47
Comments
@hipstersmoothie I'll look into this - I haven't tested it with HTML only, but it should work. |
If this is referring to creating a Sketch file from a built Storybook, as of Storybook v6 file urls do not work (see storybookjs/storybook#7215 (comment)). You must use |
@itsderek23 I believe this issue was before Storybook 6 existed. Are you successfully using story2sketch on an HTML-only storybook? |
Ah.
Yes if using |
Great, thanks for clarifying! |
I get the following error trying to use my html storybook
cessing 1 stories...
Error: Evaluation failed: TypeError: node.getBoundingClientRect is not a function
at nodeTreeToSketchGroup (/Users/alisowski/Documents/intuit-components/node_modules/story2sketch/lib/server/../browser/page2layers.bundle.js:1693:18)
at Object.getSymbol (/Users/alisowski/Documents/intuit-components/node_modules/story2sketch/lib/server/../browser/page2layers.bundle.js:2066:103)
at puppeteer_evaluation_script:4:12
at ExecutionContext.evaluateHandle (/Users/alisowski/Documents/intuit-components/node_modules/puppeteer/lib/ExecutionContext.js:90:15)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
-- ASYNC --
at ExecutionContext. (/Users/alisowski/Documents/intuit-components/node_modules/puppeteer/lib/helper.js:144:27)
at ExecutionContext.evaluate (/Users/alisowski/Documents/intuit-components/node_modules/puppeteer/lib/ExecutionContext.js:58:31)
at ExecutionContext. (/Users/alisowski/Documents/intuit-components/node_modules/puppeteer/lib/helper.js:145:23)
at Frame.evaluate (/Users/alisowski/Documents/intuit-components/node_modules/puppeteer/lib/FrameManager.js:439:20)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
-- ASYNC --
at Frame. (/Users/alisowski/Documents/intuit-components/node_modules/puppeteer/lib/helper.js:144:27)
at Page.evaluate (/Users/alisowski/Documents/intuit-components/node_modules/puppeteer/lib/Page.js:736:43)
at Page. (/Users/alisowski/Documents/intuit-components/node_modules/puppeteer/lib/helper.js:145:23)
at Story2sketch._callee5$ (/Users/alisowski/Documents/intuit-components/node_modules/story2sketch/lib/server/Story2sketch.js:532:29)
at tryCatch (/Users/alisowski/Documents/intuit-components/node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (/Users/alisowski/Documents/intuit-components/node_modules/regenerator-runtime/runtime.js:296:22)
at Generator.prototype.(anonymous function) [as next] (/Users/alisowski/Documents/intuit-components/node_modules/regenerator-runtime/runtime.js:114:21)
at step (/Users/alisowski/Documents/intuit-components/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at /Users/alisowski/Documents/intuit-components/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
at
-- ASYNC --
at Page. (/Users/alisowski/Documents/intuit-components/node_modules/puppeteer/lib/helper.js:144:27)
at Story2sketch._callee5$ (/Users/alisowski/Documents/intuit-components/node_modules/story2sketch/lib/server/Story2sketch.js:532:29)
at tryCatch (/Users/alisowski/Documents/intuit-components/node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (/Users/alisowski/Documents/intuit-components/node_modules/regenerator-runtime/runtime.js:296:22)
at Generator.prototype.(anonymous function) [as next] (/Users/alisowski/Documents/intuit-components/node_modules/regenerator-runtime/runtime.js:114:21)
at step (/Users/alisowski/Documents/intuit-components/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at /Users/alisowski/Documents/intuit-components/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
at
at process._tickCallback (internal/process/next_tick.js:188:7)
Success! 0 stories written to /Users/alisowski/Documents/intuit-components/out/ttds.asketch.json
✨ Done in 2.94s.
The text was updated successfully, but these errors were encountered: