[ENH] Add schema support to collection configuration

Author: jairad26

chromadb/api/collection_configuration.py

@@ -6,6 +6,7 @@
     UpdateMetadata,
     EmbeddingFunction,
 )
+from chromadb.base_types import CollectionSchema, ValueType
 from chromadb.utils.embedding_functions import (
     known_embedding_functions,
     register_embedding_function,
@@ -41,6 +42,7 @@ class CollectionConfiguration(TypedDict, total=True):
     hnsw: Optional[HNSWConfiguration]
     spann: Optional[SpannConfiguration]
     embedding_function: Optional[EmbeddingFunction]  # type: ignore
+    schema: Optional[Dict[str, Dict[ValueType, CollectionSchema]]]
 
 
 def load_collection_configuration_from_json_str(
@@ -106,6 +108,7 @@ def load_collection_configuration_from_json(
         hnsw=hnsw_config,
         spann=spann_config,
         embedding_function=ef,  # type: ignore
+        schema=config_json_map.get("schema"),
     )
 
 
@@ -118,6 +121,7 @@ def collection_configuration_to_json(config: CollectionConfiguration) -> Dict[st
         hnsw_config = config.get("hnsw")
         spann_config = config.get("spann")
         ef = config.get("embedding_function")
+        schema = config.get("schema")
     else:
         try:
             hnsw_config = config.get_parameter("hnsw").value
@@ -172,6 +176,7 @@ def collection_configuration_to_json(config: CollectionConfiguration) -> Dict[st
         "hnsw": hnsw_config,
         "spann": spann_config,
         "embedding_function": ef_config,
+        "schema": schema,
     }
 
 
@@ -252,6 +257,7 @@ class CreateCollectionConfiguration(TypedDict, total=False):
     hnsw: Optional[CreateHNSWConfiguration]
     spann: Optional[CreateSpannConfiguration]
     embedding_function: Optional[EmbeddingFunction]  # type: ignore
+    schema: Optional[Dict[str, Dict[ValueType, CollectionSchema]]]
 
 
 def create_collection_configuration_from_legacy_collection_metadata(
@@ -379,6 +385,7 @@ def create_collection_configuration_to_json(
         "hnsw": hnsw_config,
         "spann": spann_config,
         "embedding_function": ef_config,
+        "schema": config.get("schema"),
     }
 
 
@@ -450,6 +457,7 @@ class UpdateCollectionConfiguration(TypedDict, total=False):
     hnsw: Optional[UpdateHNSWConfiguration]
     spann: Optional[UpdateSpannConfiguration]
     embedding_function: Optional[EmbeddingFunction]  # type: ignore
+    schema: Optional[Dict[str, Dict[ValueType, CollectionSchema]]]
 
 
 def update_collection_configuration_from_legacy_collection_metadata(
@@ -504,8 +512,14 @@ def update_collection_configuration_to_json(
     """Convert an UpdateCollectionConfiguration to a JSON-serializable dict"""
     hnsw_config = config.get("hnsw")
     spann_config = config.get("spann")
+    schema = config.get("schema")
     ef = config.get("embedding_function")
-    if hnsw_config is None and spann_config is None and ef is None:
+    if (
+        hnsw_config is None
+        and spann_config is None
+        and ef is None
+        and schema is None
+    ):
         return {}
 
     if hnsw_config is not None:
@@ -539,6 +553,7 @@ def update_collection_configuration_to_json(
         "hnsw": hnsw_config,
         "spann": spann_config,
         "embedding_function": ef_config,
+        "schema": schema,
     }
 
 
@@ -687,13 +702,40 @@ def overwrite_collection_configuration(
         else:
             updated_embedding_function = update_ef
 
+
+    existing_schema = existing_config.get("schema")
+    new_diff_schema = update_config.get("schema")
+    updated_schema: Optional[Dict[str, Dict[ValueType, CollectionSchema]]] = None
+    if existing_schema is not None:
+        if new_diff_schema is not None:
+            updated_schema = overwrite_schema(existing_schema, new_diff_schema)
+        else:
+            updated_schema = existing_schema
+    else:
+        updated_schema = new_diff_schema
+
     return CollectionConfiguration(
         hnsw=updated_hnsw_config,
         spann=updated_spann_config,
         embedding_function=updated_embedding_function,
+        schema=updated_schema,
     )
 
 
+def overwrite_schema(
+    existing_schema: Dict[str, Dict[ValueType, CollectionSchema]],
+    new_diff_schema: Dict[str, Dict[ValueType, CollectionSchema]],
+) -> Dict[str, Dict[ValueType, CollectionSchema]]:
+    """Overwrite a schema with a new configuration"""
+    for new_key, new_value in new_diff_schema.items():
+        if new_key in existing_schema:
+            for value_type, new_schema in new_value.items():
+                existing_schema[new_key][value_type] = new_schema
+        else:
+            existing_schema[new_key] = new_value
+    return existing_schema
+
+
 def validate_embedding_function_conflict_on_create(
     embedding_function: Optional[EmbeddingFunction],  # type: ignore
     configuration_ef: Optional[EmbeddingFunction],  # type: ignore

chromadb/api/models/AsyncCollection.py

@@ -60,15 +60,22 @@ async def add(
             ValueError: If you provide an id that already exists
 
         """
-        add_request = self._validate_and_prepare_add_request(
+
+        curr_schema = self._model.get_configuration().get("schema")
+
+        add_request, new_attributes = self._validate_and_prepare_add_request(
             ids=ids,
             embeddings=embeddings,
             metadatas=metadatas,
             documents=documents,
             images=images,
             uris=uris,
+            schema=curr_schema,
         )
 
+        if len(new_attributes.keys()) > 0:
+            await self.modify(configuration={"schema": new_attributes})
+
         await self._client._add(
             collection_id=self.id,
             ids=add_request["ids"],
@@ -313,15 +320,20 @@ async def update(
         Returns:
             None
         """
-        update_request = self._validate_and_prepare_update_request(
+        curr_schema = self._model.get_configuration().get("schema")
+        update_request, new_attributes = self._validate_and_prepare_update_request(
             ids=ids,
             embeddings=embeddings,
             metadatas=metadatas,
             documents=documents,
             images=images,
             uris=uris,
+            schema=curr_schema,
         )
 
+        if len(new_attributes.keys()) > 0:
+            await self.modify(configuration={"schema": new_attributes})
+
         await self._client._update(
             collection_id=self.id,
             ids=update_request["ids"],
@@ -358,14 +370,18 @@ async def upsert(
         Returns:
             None
         """
-        upsert_request = self._validate_and_prepare_upsert_request(
+        curr_schema = self._model.get_configuration().get("schema")
+        upsert_request, new_attributes = self._validate_and_prepare_upsert_request(
             ids=ids,
             embeddings=embeddings,
             metadatas=metadatas,
             documents=documents,
             images=images,
             uris=uris,
+            schema=curr_schema,
         )
+        if len(new_attributes.keys()) > 0:
+            await self.modify(configuration={"schema": new_attributes})
 
         await self._client._upsert(
             collection_id=self.id,

chromadb/api/models/Collection.py

@@ -77,15 +77,20 @@ def add(
 
         """
 
-        add_request = self._validate_and_prepare_add_request(
+        curr_schema = self._model.get_configuration().get("schema")
+        add_request, new_attributes = self._validate_and_prepare_add_request(
             ids=ids,
             embeddings=embeddings,
             metadatas=metadatas,
             documents=documents,
             images=images,
             uris=uris,
+            schema=curr_schema,
         )
 
+        if len(new_attributes.keys()) > 0:
+            self.modify(configuration={"schema": new_attributes})
+
         self._client._add(
             collection_id=self.id,
             ids=add_request["ids"],
@@ -255,6 +260,7 @@ def modify(
         # Note there is a race condition here where the metadata can be updated
         # but another thread sees the cached local metadata.
         # TODO: fixme
+
         self._client._modify(
             id=self.id,
             new_name=name,
@@ -317,15 +323,20 @@ def update(
         Returns:
             None
         """
-        update_request = self._validate_and_prepare_update_request(
+        curr_schema = self._model.get_configuration().get("schema")
+        update_request, new_attributes = self._validate_and_prepare_update_request(
             ids=ids,
             embeddings=embeddings,
             metadatas=metadatas,
             documents=documents,
             images=images,
             uris=uris,
+            schema=curr_schema,
         )
 
+        if len(new_attributes.keys()) > 0:
+            self.modify(configuration={"schema": new_attributes})
+
         self._client._update(
             collection_id=self.id,
             ids=update_request["ids"],
@@ -362,15 +373,20 @@ def upsert(
         Returns:
             None
         """
-        upsert_request = self._validate_and_prepare_upsert_request(
+        curr_schema = self._model.get_configuration().get("schema")
+        upsert_request, new_attributes = self._validate_and_prepare_upsert_request(
             ids=ids,
             embeddings=embeddings,
             metadatas=metadatas,
             documents=documents,
             images=images,
             uris=uris,
+            schema=curr_schema,
         )
 
+        if len(new_attributes.keys()) > 0:
+            self.modify(configuration={"schema": new_attributes})
+
         self._client._upsert(
             collection_id=self.id,
             ids=upsert_request["ids"],