Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other browser vendors #62

Open
mohamedmansour opened this issue May 1, 2020 · 0 comments
Open

Add support for other browser vendors #62

mohamedmansour opened this issue May 1, 2020 · 0 comments

Comments

@mohamedmansour
Copy link

Other browser vendors use different assembly name and profile paths, for example in Microsoft Edge Chromium, we use msedge.exe and Edge SxS.

By doing the following, VsChromium could work with any major vendor like Brave, Chrome, Edge, Opera, Vivaldi,

Here are the areas that require modification:

Booleans

Examples:

file.Equals("chrome.exe", StringComparison.CurrentCultureIgnoreCase)
InstallationPath.HasComponent("Chrome SxS")
InstallationPath.HasComponent("Chrome")

Potential Solution:
Utility class that takes a lambda, and it will transform that to N browser vendors.

Strings

Examples:

Path.Combine(location, "chrome.exe")
Path.Combine(_installationData.InstallationPath.Value, "chrome.exe")

Potential Solutions:
Utility class that takes a folder, and makes sure from N browser vendors it exists. Then returns the path.

Arrays

Examples:

Process.GetProcessesByName("chrome")

Potential Solution:
Return all processes from all vendors.

Renaming them to Chromium

Examples:

this.Text = "Attach to Chrome";
[Category("Chrome Debugging")]

Potential Solution:
Just to signify its Chromium and not Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant