We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other browser vendors use different assembly name and profile paths, for example in Microsoft Edge Chromium, we use msedge.exe and Edge SxS.
msedge.exe
Edge SxS
By doing the following, VsChromium could work with any major vendor like Brave, Chrome, Edge, Opera, Vivaldi,
Examples:
file.Equals("chrome.exe", StringComparison.CurrentCultureIgnoreCase) InstallationPath.HasComponent("Chrome SxS") InstallationPath.HasComponent("Chrome")
Potential Solution: Utility class that takes a lambda, and it will transform that to N browser vendors.
Path.Combine(location, "chrome.exe") Path.Combine(_installationData.InstallationPath.Value, "chrome.exe")
Potential Solutions: Utility class that takes a folder, and makes sure from N browser vendors it exists. Then returns the path.
Process.GetProcessesByName("chrome")
Potential Solution: Return all processes from all vendors.
this.Text = "Attach to Chrome"; [Category("Chrome Debugging")]
Potential Solution: Just to signify its Chromium and not Chrome
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Other browser vendors use different assembly name and profile paths, for example in Microsoft Edge Chromium, we use
msedge.exe
andEdge SxS
.By doing the following, VsChromium could work with any major vendor like Brave, Chrome, Edge, Opera, Vivaldi,
Here are the areas that require modification:
Booleans
Examples:
Potential Solution:
Utility class that takes a lambda, and it will transform that to N browser vendors.
Strings
Examples:
Potential Solutions:
Utility class that takes a folder, and makes sure from N browser vendors it exists. Then returns the path.
Arrays
Examples:
Potential Solution:
Return all processes from all vendors.
Renaming them to Chromium
Examples:
Potential Solution:
Just to signify its Chromium and not Chrome
The text was updated successfully, but these errors were encountered: