Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport_tuning updates not propagated to OSCORE #378

Open
lemikev opened this issue Feb 18, 2025 · 1 comment
Open

transport_tuning updates not propagated to OSCORE #378

lemikev opened this issue Feb 18, 2025 · 1 comment

Comments

@lemikev
Copy link

lemikev commented Feb 18, 2025

The update of the transport_tuning constant(s) don't seem to work for OSCORE messages.
For example, the following code works for CoAP but not for OSCORE.

    request.mtype = aiocoap.CON
    request.transport_tuning.MAX_RETRANSMIT = 1
    response = await aiocoap_context.request(request).response

To fix the issue, I had to add the following line in oscore.py

        outer_message = Message(
            code=outer_code,
            uri_host=outer_host,
            observe=None if message.code.is_response() else message.opt.observe,
        )

        # BUG fix
        outer_message.transport_tuning = inner_message.transport_tuning
@chrysn
Copy link
Owner

chrysn commented Feb 24, 2025

Thanks for the report and the workaround. This should indeed be transparent, I'll have to look into how to set it so that there can still be transport tuning for OSCORE in addition to any next layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants