Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Release planned to include "Added checks for retrieving number facets in case of bad config"? #42

Open
tblong opened this issue Apr 2, 2024 · 5 comments

Comments

@tblong
Copy link

tblong commented Apr 2, 2024

Specifically interested if there is a release planned to include this commit: ec59e60

@ci-richard-mcelhinney
Copy link
Owner

Hi @tblong ,

As an open source project the code is available for anyone to build. Having said that it has been a while since I did a new build so I should do one soon. I'll try to get one out.

The tricky part is testing it on different versions of Niagara. So if you can help with that it would be appreciated.

@tblong
Copy link
Author

tblong commented Apr 12, 2024

As an open source project the code is available for anyone to build

Understood completely. If given access to the code signing cert and write permissions to this repo I would help with compiling, testing, and publishing the release build myself.

I have access to all presently supported versions of Niagara, so v4.10, 4.12, and 4.13. If you have an idea of what bugs, features, commits should be tested manually then happy to do so.

@ci-richard-mcelhinney
Copy link
Owner

@tblong you don't need the official signing cert to produce your own build. You can use a self-signed cert or buy your own code signing certificate. All the certificate does is certify that whoever built the code stands by the code.

I appreciate your offer of testing and I'll take you up on that, perhaps we can communicate offline for this. Mostly the testing between different versions is just sanity testing that it boots up and generally works as expected in each version. I'd like to get to the point of being able to document tests, perhaps we can work on this together. I'll make an effort to do a build and lets take it from there.

@tblong
Copy link
Author

tblong commented Apr 12, 2024

You can use a self-signed cert or buy your own code signing certificate. All the certificate does is certify that whoever built the code stands by the code.

Yes, though it would not be an official build from this repo's cert and then the community would end up not benefitting. I could fork then sign with our own cert, however that would just further fragment this work and cause confusion for end users over who's published version should be used.

Good to take this offline and help document any part of the manual testing steps taken.

@tblong
Copy link
Author

tblong commented May 23, 2024

Hey @ci-richard-mcelhinney, still happy to help test here. Let me know how you might like to take this offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants