find dropdown root using trigger.parentElement #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- will-destroy can run at the same tick as dropdown content removal
|
Closing this for now - realised that the named block isn't strict about where you render your dropdown content, so this may mess up behaviour of some dropdowns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #583
will-destroycan run at the same tick as dropdown content removal. If it is indeed removed from the DOM, we would not be able to find the container by starting from the dropdown content, so this PR uses the trigger to find the container instead.It seems difficult to test this - I've tried using paused animations (but this doesn't play nice with
waitForAnimationswhich only waits for a running animation), however I'd be happy to implement suggestions.