Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pr-bumper check passing with invalid config #103

Open
job13er opened this issue Jun 8, 2017 · 0 comments
Open

pr-bumper check passing with invalid config #103

job13er opened this issue Jun 8, 2017 · 0 comments
Assignees
@job13er
Labels
bug

Comments

@job13er
Copy link
Contributor

job13er commented Jun 8, 2017

We've seen multiple instances now of improper configured .pr-bumper.json files making it past pr-bumper check only to fail at pr-bumper bump with 404s. We should be failing with the same 404s in pr-bumper check.

We also need to make the error messages more informative:

pr-bumper: ERROR: 404: {}

Is not very informative.
@job13er job13er self-assigned this Jun 8, 2017
@job13er job13er added the bug label Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@job13er job13er

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@job13er