Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write tests for edit_dynamics #14

Open
raphaelDkhn opened this issue Sep 23, 2023 · 4 comments
Open

feat: write tests for edit_dynamics #14

raphaelDkhn opened this issue Sep 23, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request ODHack

Comments

@raphaelDkhn
Copy link
Collaborator

Add or modify dynamics (velocity) of notes based on a specified curve or pattern.

    fn edit_dynamics(self: @Midi, curve: VelocityCurve) -> Midi;
@raphaelDkhn raphaelDkhn added the enhancement New feature or request label Sep 23, 2023
@caseywescott caseywescott self-assigned this Nov 14, 2023
@Oshioke-Salaki
Copy link

Can I be assigned this?

@caseywescott
Copy link
Collaborator

Hey! The basic implementation is here:

fn edit_dynamics(self: @Midi, curve: VelocityCurve) -> Midi {

Would you want to write a test for it? I can change the issue for that...

@Oshioke-Salaki
Copy link

edit_dynamics

Hey please is there a telegram group where i can contact the project coordinators?

@raphaelDkhn
Copy link
Collaborator Author

raphaelDkhn commented Mar 18, 2024

Hey @Oshioke-Salaki ! Here is the TG chat:
https://t.me/niceralabs

@raphaelDkhn raphaelDkhn changed the title feat: edit_dynamics feat: write tests for edit_dynamics Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ODHack
Projects
None yet
Development

No branches or pull requests

3 participants