Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cairto to Midi transpiler #38

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AryanGodara
Copy link
Contributor

@AryanGodara AryanGodara commented Mar 19, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently we support midi to cairo conversions, but not the other way round

Issue Number: Resolves #36

What is the new behavior?

Implementes cairo_struct_to_midi convertor function

  • Updated Makefile with new endpoint
  • Updated cli.py to accept a generic input_file instead of having a hardcoded midi_file as input
  • Added functionality to be able to interconvert MIDI<>cairo

Does this introduce a breaking change?

  • Yes
  • No

The Makefile targets have been updated, so the README has been updated as well.

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Create Cairo2Midi transpiler
1 participant