Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add locale to movie module #895

Closed
cieslarmichal opened this issue Sep 7, 2024 · 6 comments · Fixed by #1000
Closed

add locale to movie module #895

cieslarmichal opened this issue Sep 7, 2024 · 6 comments · Fixed by #1000
Assignees
@SgtApone117
Labels
good first issue Good for newcomers
Milestone
v4.0.0

Comments

@cieslarmichal
Copy link
Owner

ref book module
@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Sep 7, 2024
@cieslarmichal cieslarmichal added this to the v4.0.0 milestone Oct 1, 2024
@SgtApone117
Copy link
Contributor

Hey, i want to work on this. Thank you

@cieslarmichal
Copy link
Owner Author

ok assigned

@cieslarmichal
Copy link
Owner Author

any progress?

@SgtApone117
Copy link
Contributor

Hi michael, i would complete in couple of days. Sorry for the delay. Thank you.

@SgtApone117
Copy link
Contributor

I referred the book module, do I have to also implement for Pl-pl version like a default version apart from en-us?

@cieslarmichal
Copy link
Owner Author

No you dont have but it would be nice to add one more locale than english, doesnt have to be polish

@SgtApone117 SgtApone117 mentioned this issue Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtApone117 SgtApone117

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

feat: Added locale for movies SgtApone117/faker-cxx
2 participants
@SgtApone117 @cieslarmichal