Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response.resume() does not work #146

Open
mikesway opened this issue Dec 6, 2023 · 2 comments
Open

Response.resume() does not work #146

mikesway opened this issue Dec 6, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mikesway
Copy link
Contributor

mikesway commented Dec 6, 2023

Describe the bug
The resume() method does not work on Response although pause() does. I traced this down to the uWebSockets uws_res_resume() API calling uwsRes->pause() instead of uwsRes->resume(). There was a bug filed there and just fixed: uNetworking/uWebSockets#1686

To Reproduce
I reproduced by uploading a large file to a route. I was able to pause it correctly with pause() but I could never get it to resume with resume(). It would always just remain stuck.

I actually patched and rebuilt the uWebSocket .so libraries with the fix locally and it seems to work well.

Expected behavior
The resume() should continue the upload after pausing.
@cirospaciari
Copy link
Owner

Oh I will push this fix and other fixes this week end, thanks for reporting!

@mikesway
Copy link
Contributor Author

It's been a couple weeks, any progress here? Is there something I can do to help?

@cirospaciari cirospaciari added the bug Something isn't working label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cirospaciari @mikesway