Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with UserPassBaseLimiter #28

Open
tvdijen opened this issue Oct 26, 2022 · 3 comments
Open

Bug with UserPassBaseLimiter #28

tvdijen opened this issue Oct 26, 2022 · 3 comments

Comments

@tvdijen
Copy link
Contributor

tvdijen commented Oct 26, 2022

Oct 26 11:36:10 IDP[6695]: 3 [f1b9757f3e] Caused by: TypeError: Return value of SimpleSAML\Module\ratelimit\Limiters\UserPassBaseLimiter::getCurrentCount() must be of the type int, object returned

To me, this only seems possible if an object was stored in the first place, but I don't see how that could happen. The store used is memcached.

@tvdijen
Copy link
Contributor Author

tvdijen commented Oct 26, 2022

I found out that the object is of type SimpleSAML\Session...

@pradtke
Copy link
Contributor

pradtke commented Oct 28, 2022

That is perplexing. The session storage stuff puts a .session. in its key names and rate limiting puts a .int.ratelimit in its key names. It seems unlikely that they would both generate an identical key. I'm not sure where that leaves us for figuring out the cause.

@tvdijen
Copy link
Contributor Author

tvdijen commented Oct 28, 2022

Yeah, it's really weird.. I haven't been able to figure it out.. Restarting memcached solved the problem and I haven't seen this error since, so there must have been some kind of interference...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants