Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are sub-types supported ? #26

Open
kohsah opened this issue Mar 11, 2016 · 7 comments
Open

Are sub-types supported ? #26

kohsah opened this issue Mar 11, 2016 · 7 comments

Comments

@kohsah
Copy link
Contributor

kohsah commented Mar 11, 2016

I noticed in structure.json, the docTypesstructure takes only the high-level docType name ("doc", "bill" ... ). Is it possible to have two "doc" docTypes but having a different sub-Type name ? something like :


  "docTypes": [
      {
         "name": "doc",
         "subType": "adoc",
          locales: [ ... ]
     },
     {
         "name": "doc",
         "subType": "bdoc",
          locales: [ ... ]
    }
]
@obujor
Copy link
Contributor

obujor commented Mar 11, 2016

By now the subtype is taken from the document on marking of the "docType" element, and it is shown only in the uri.

@kohsah
Copy link
Contributor Author

kohsah commented Mar 30, 2016

Hi @obujor I am working on supporting languagePlugins by documentType + subType . I have multiple documents of type debateReport which differ on subType .. and a similar case with "doc" document Type.

@obujor
Copy link
Contributor

obujor commented Mar 31, 2016

Great! Do the subType documents need different buttons which are not included in documentType? Where you would like to insert the subType in Akoma?

@kohsah
Copy link
Contributor Author

kohsah commented Mar 31, 2016

Yeah there are cases where they would need different buttons - not different buttons per se... but for 1 type I don't want to show some buttons . I have a case where the two documents are very similar in structure (modeled on debateReport) and other cases where the documents are structurally different (even if modeled on doc). I think this is pretty much a valid scenario when you consider the generic doc / debateReport types.

So in the current scenario when I say new document, it is a AN document type that is provided, but in reality you could have multiple document types in an organization mapped to a AN document type ... and you differentiate based on sub-type.

@obujor
Copy link
Contributor

obujor commented Mar 31, 2016

Ok, this makes sense.
Thanks!

@kohsah
Copy link
Contributor Author

kohsah commented Apr 5, 2016

@obujor I am testing this functionality at the moment, will be sending a PR in a day or two.

@obujor
Copy link
Contributor

obujor commented May 2, 2017

The pull request #36 provides an implementation for this feature but we were waiting for a rework to merge it, finally we closed the pull request because the rework wasn't submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants