Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen the dependencies warning #1469

Open
adhilto opened this issue Dec 11, 2024 · 0 comments
Open

Strengthen the dependencies warning #1469

adhilto opened this issue Dec 11, 2024 · 0 comments
Assignees
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@adhilto
Copy link
Collaborator

adhilto commented Dec 11, 2024

💡 Summary

Strengthen the warning presented when the proper versions of ScubaGear's dependencies are not installed. Perhaps add something like "ScubaGear may not function properly until the supporting modules are installed."

Motivation and context

The current warning is very ignorable -- and sometimes you can get away with ignoring it. But ignoring it can also cause significant exceptions to occur. Strengthening the warning would help the users understand the potential risks of ignoring it.

Implementation notes

The warning currently reads as:

The required supporting PowerShell modules are not installed with a supported version.
Run Initialize-SCuBA to install all required dependencies.
See Get-Help Initialize-SCuBA for more help.

See PowerShell/ScubaGear/Dependencies.ps1.

Acceptance criteria

The warning clearly states the risks involved.

@adhilto adhilto added the enhancement This issue or pull request will add new or improve existing functionality label Dec 11, 2024
@schrolla schrolla added this to the Lionfish milestone Dec 16, 2024
@schrolla schrolla assigned schrolla and adhilto and unassigned schrolla Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants