Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvement: modal gets read out twice #1612

Open
gabo0oo opened this issue Jan 9, 2024 · 11 comments · May be fixed by #3574
Open

Accessibility improvement: modal gets read out twice #1612

gabo0oo opened this issue Jan 9, 2024 · 11 comments · May be fixed by #3574
Assignees
Labels
accessibility pertains to Section 508 compliance or other accessibility needs bug Something that isn't working as intended 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant dev issue is for the dev team

Comments

@gabo0oo
Copy link
Contributor

gabo0oo commented Jan 9, 2024

  • Encountered using VO on Mac
  • When opening the modal with VO on, I'm read the entire contents of the modal twice.
  • How replicate: See USWDS modal component, turn on VO or other screen reader and trigger the modal. See that it only reads off once. Go to our app, go to the dashboard and trigger the modal by clicking "Delete", see how the modal gets read off twice.
  • Note I don't know if this occurs on other screen readers. I only observed this on VO (native mac app).
  • This is occurring on all modals

Originally posted by @gabydisarli in #1590 (comment)

Prioritization Comments

WCAG Conformance Level:
WCAG Standard that applies:
Critical Failure if Not Met?:
Prioritization:
Reason:

@gabo0oo
Copy link
Contributor Author

gabo0oo commented Jan 9, 2024

@zandercymatics FYSA

@vickyszuchin vickyszuchin added the dev issue is for the dev team label Jan 9, 2024
@PaulKuykendall PaulKuykendall added the bug Something that isn't working as intended label Jan 22, 2024
@PaulKuykendall PaulKuykendall moved this from 👶 New to 🍦 Backlog in .gov Product Board Jan 22, 2024
@vickyszuchin
Copy link

This bug has been sized by dev and meets the DoR criteria. Moving it to "Ready."

@vickyszuchin vickyszuchin moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Apr 30, 2024
@katypies katypies added the accessibility pertains to Section 508 compliance or other accessibility needs label Jun 24, 2024
@PaulKuykendall
Copy link

@AnnaGingle - can you verify that this is still a problem?? Thanks

@AnnaGingle
Copy link

@gabydisarli Is this on every modal?

@gabo0oo
Copy link
Contributor Author

gabo0oo commented Sep 23, 2024

@AnnaGingle I made this issue a really long time ago so I would have to go in a check it all again. I did a quick check on the modal that appears on the submit your domain request button on the review page and I hear it read out twice. When first opened, the entire modal gets read out, then it says "Dialog" then reads it all out again. I hear this using VO on my mac.

@AnnaGingle
Copy link

@gabydisarli Can you record what you're seeing / hearing with Quicktime player?

@gabo0oo
Copy link
Contributor Author

gabo0oo commented Oct 9, 2024

recording of the VO dialog on the uswds component
https://github.com/user-attachments/assets/8668cc8f-7599-41fd-a83c-8c2837826394

recording of the VO dialog on the submit your domain request modal. Note that visually nothing changes on the dialog window but what I hear is the modal get read out and then "dialog:" and the modal gets read out a 2nd time. On USWDS the modal reads it out once. It says "dialog" before it gets read out, exactly the same way that the 2nd round of ours gets read out.
https://github.com/user-attachments/assets/d021729a-e8a1-4b34-b51d-5daa2cc346d1

@gabo0oo
Copy link
Contributor Author

gabo0oo commented Oct 9, 2024

@AnnaGingle ^see recordings above

@gabo0oo
Copy link
Contributor Author

gabo0oo commented Oct 10, 2024

Weirdly, I don't see this happening on the Delete a domain request button anymore. I didn't check all modals but am using the submit your domain request modal as an example.

@zandercymatics zandercymatics self-assigned this Feb 25, 2025
@zandercymatics zandercymatics added the 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant label Feb 25, 2025
@zandercymatics zandercymatics moved this from 🎯 Ready to 🏗 In progress in .gov Product Board Feb 25, 2025
@zandercymatics
Copy link
Contributor

zandercymatics commented Feb 25, 2025

Changed size from 3 => 2

@zandercymatics
Copy link
Contributor

I've narrowed this issue down to a library issue with USWDS. I've filed a bug ticket here but will look into modifying our custom uswds.js file to see if I can resolve this issue directly

@zandercymatics zandercymatics moved this from 🏗 In progress to 👀 In review in .gov Product Board Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility pertains to Section 508 compliance or other accessibility needs bug Something that isn't working as intended 👥 Pod:Accessibility Compliance Describes work needed for get.gov and manage.get.gov to be Section 508 Compliant dev issue is for the dev team
Projects
Status: 👀 In review
6 participants